Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to signal a manual flush to stream FileSubscriber #4871

Merged
merged 3 commits into from
Aug 3, 2021

Conversation

Arkatufus
Copy link
Contributor

Closes #4867

@Aaronontheweb What do you think of this implementation

Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - looks like a reasonable way to side-car an Akka.Streams

@Aaronontheweb Aaronontheweb self-requested a review April 14, 2021 18:39
Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Arkatufus Arkatufus marked this pull request as ready for review July 8, 2021 13:58
@Aaronontheweb Aaronontheweb enabled auto-merge (squash) August 3, 2021 20:22
# Conflicts:
#	src/core/Akka.Streams.Tests/IO/FileSinkSpec.cs
#	src/core/Akka.Streams/Implementation/IO/FileSubscriber.cs
@Aaronontheweb Aaronontheweb merged commit 6967338 into akkadotnet:dev Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Akka.Streams.IO: need to add "Flush" command for FileIO that can be invoked from outside
2 participants