Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PersistenceBenchmark #5506

Closed
Aaronontheweb opened this issue Jan 13, 2022 · 3 comments · Fixed by #5509 or #6428
Closed

Remove PersistenceBenchmark #5506

Aaronontheweb opened this issue Jan 13, 2022 · 3 comments · Fixed by #5509 or #6428

Comments

@Aaronontheweb
Copy link
Member

Our Akka.Persistence benchmarks are pretty ancient https://github.com/akkadotnet/akka.net/blob/dev/src/benchmark/PersistenceBenchmark/Program.cs

I'll see about adding some BenchmarkDotNet ones.

Originally posted by @Aaronontheweb in #5505 (comment)


We should delete the PersistenceBenchmark - byte rotted and we'd prefer a BenchmarkDotNet solution here.

@Aaronontheweb
Copy link
Member Author

Still have to remove the old benchmarks even if we have a decent replacement for them now

@dengia
Copy link
Contributor

dengia commented Jan 17, 2023

Hi @Aaronontheweb, I went through benchmarks:
PersistentBenchamarks --> Akka.Cluster.Benchmarks/Persistence
PingPong --> Akka.Benchmarks/Actor/PingPongBenchmarks.cs
SerializationBenchmarks --> Akka.Benchmarks/Actor/Serialization
RemotePingPong --> ?
SpawnBenchmark --> ?
Question: is this correct? If yes, shall I remove those three old benchmarks with decent replacement?

@Aaronontheweb
Copy link
Member Author

@dengia those benchmarks are fine, it's just this folder that needs to be deleted https://github.com/akkadotnet/akka.net/tree/dev/src/benchmark/PersistenceBenchmark

Aaronontheweb added a commit to Aaronontheweb/akka.net that referenced this issue Feb 21, 2023
@Aaronontheweb Aaronontheweb moved this from Todo to Spec Approved in Akka.NET v1.5 Total Delivery Feb 21, 2023
@Aaronontheweb Aaronontheweb moved this from Spec Approved to In Progress in Akka.NET v1.5 Total Delivery Feb 21, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Akka.NET v1.5 Total Delivery Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
2 participants