Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use IOException instead of FileLoadException to handle #269 where an … #270

Merged
merged 1 commit into from
Oct 21, 2021
Merged

Use IOException instead of FileLoadException to handle #269 where an … #270

merged 1 commit into from
Oct 21, 2021

Conversation

jarlebh
Copy link
Contributor

@jarlebh jarlebh commented Oct 8, 2021

Use IOException instead of FileLoadException to handle #269 where an FileNotFoundException is thrown

Use IOException instead of FileLoadException to handle akkadotnet#269 …
b26187f 
…where an FileNotFoundExeption is thrown.
Aaronontheweb
Aaronontheweb requested changes Oct 19, 2021
View reviewed changes
Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See previous comments - need to make sure we don't break compat with older platforms prior to .NET 5 too.

src/Hyperion/Extensions/TypeEx.cs Show resolved Hide resolved
@Aaronontheweb Aaronontheweb merged commit 52ec792 into akkadotnet:dev Oct 21, 2021
@Aaronontheweb Aaronontheweb mentioned this pull request Oct 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aaronontheweb Aaronontheweb Aaronontheweb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jarlebh @Aaronontheweb