Fix azure bugs, expand logging #2890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arkatufus
commented
Nov 8, 2024
|
|
||
| public AzureApiImpl(ActorSystem system, AzureLeaseSettings settings) | ||
| { | ||
| _settings = settings; | ||
| _log = Logging.GetLogger(system, GetType()); | ||
|
|
||
| _containerClient = new Lazy<BlobContainerClient>(() => |
There was a problem hiding this comment.
Actual fix, removed Lazy<T> because it is caching container client value.
Comment on lines
+68
to
+84
| private async Task<BlobContainerClient> ContainerClient() | ||
| { | ||
| var serviceClient = _settings.AzureCredential != null && _settings.ServiceEndpoint != null | ||
| ? new BlobServiceClient(_settings.ServiceEndpoint, _settings.AzureCredential, _settings.BlobClientOptions) | ||
| : new BlobServiceClient(_settings.ConnectionString); | ||
|
|
||
| var client = serviceClient.GetBlobContainerClient(_settings.ContainerName); | ||
|
|
||
| // Make sure that `CreateIfNotExistsAsync()` only get called once for every AzureApi instance | ||
| if (!_initialized) | ||
| { | ||
| await client.CreateIfNotExistsAsync(); | ||
| _initialized = true; | ||
| } | ||
|
|
||
| return client; | ||
| } |
There was a problem hiding this comment.
Actual fix, instead of using Lazy<T>, make sure that a new container client is instantiated every time a container client is requested, but only try to initialize the azure container once for every instance of AzureApiImpl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to akkadotnet/akka.net#7379
Changes
LeaseActorfrom/userto/systemChecklist
For significant changes, please ensure that the following have been completed (delete if not relevant):