added AddHoconFile method
#58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows Akka.Hosting to automatically load HOCON from a file.
Aaronontheweb
commented
Jun 9, 2022
| @@ -36,19 +36,6 @@ public SingletonActor(IMySingletonInterface singleton) | |||
| }); | |||
| } | |||
| } | |||
|
|
|||
| private static async Task<IHost> StartHost(Action<IServiceCollection> testSetup) | |||
There was a problem hiding this comment.
Moved this to a separate TestHelpers class so it can be re-used across multiple tests
| var hocon = sys.Settings.Config; | ||
|
|
||
| // assert | ||
| hocon.HasPath("petabridge.cmd").Should().BeTrue(); |
There was a problem hiding this comment.
This is a custom HOCON section in the test.hocon file that wouldn't normally appear in default HOCON - thus it demonstrates that the file is being correctly loaded into the ActorSystem as a result of the AddHoconFile method.
| public static AkkaConfigurationBuilder AddHoconFile(this AkkaConfigurationBuilder builder, string hoconFilePath, | ||
| HoconAddMode addMode = HoconAddMode.Append) | ||
| { | ||
| var hoconText = ConfigurationFactory.ParseString(File.ReadAllText(hoconFilePath)); |
There was a problem hiding this comment.
parses the file synchronously - this will throw an exception if the file is not found, which is to be expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Allows Akka.Hosting to automatically load HOCON from a file. Solves a longtime painpoint for users where they typically had to call
ConfigurationFactory.ParseString(File.ReadAllText(filePath)). Now it's a one-liner.Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):