Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add global DData setting extension method #527

Merged
merged 3 commits into from
Nov 26, 2024
Merged

Add global DData setting extension method #527

merged 3 commits into from
Nov 26, 2024

Conversation

Arkatufus
Copy link
Contributor

@Arkatufus Arkatufus commented Nov 19, 2024 •
edited
Loading

Fixes #512

Changes

  • Make DData settings global instead of per-shard region.
  • Add unit test to make sure that all options are applied.

@Arkatufus Arkatufus mentioned this pull request Nov 19, 2024
Closed
@Arkatufus Arkatufus marked this pull request as ready for review November 25, 2024 20:32
Aaronontheweb
Aaronontheweb approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aaronontheweb Aaronontheweb merged commit 9b18651 into akkadotnet:dev Nov 26, 2024
2 checks passed
@Arkatufus Arkatufus mentioned this pull request Dec 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aaronontheweb Aaronontheweb Aaronontheweb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No way to disable DData.Durable with Akka.Hosting
2 participants
@Arkatufus @Aaronontheweb