Fix WithSingleton and WithSingletonProxy API
#520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arkatufus
commented
Nov 13, 2024
Comment on lines
+172
to
+177
| public bool? LogSingletonIdentificationFailure { get; set; } | ||
|
|
||
| /// <summary> | ||
| /// The period the proxy will wait until it logs a missing singleton warning, defaults to 1 minute | ||
| /// </summary> | ||
| public TimeSpan? SingletonIdentificationFailurePeriod { get; set; } |
There was a problem hiding this comment.
Added Akka 1.5.31 missing singleton detection feature
Comment on lines
+1291
to
+1300
| /// <list type="bullet"> | ||
| /// <item> | ||
| /// The complete singleton manager actor path name will be | ||
| /// <c>akka://MyActorSystem/user/singletonManagerName/singletonName</c> | ||
| /// </item> | ||
| /// <item> | ||
| /// The complete singleton proxy actor path name, if created, will be | ||
| /// <c>akka://MyActorSystem/user/singletonName-proxy</c> | ||
| /// </item> | ||
| /// </list> |
There was a problem hiding this comment.
Added explanation on what the actor names will be in the XML-DOC
Comment on lines
+1330
to
+1336
| public static AkkaConfigurationBuilder WithSingleton<TKey>( | ||
| this AkkaConfigurationBuilder builder, | ||
| string singletonManagerName, | ||
| string singletonName, | ||
| Func<ActorSystem, IActorRegistry, IDependencyResolver, Props> propsFactory, | ||
| ClusterSingletonOptions? options = null, | ||
| bool createProxyToo = true) |
There was a problem hiding this comment.
New API that allows users to specify the singleton manager actor name.
The resulting singleton path will be akka://MyActorSystem/user/singletonManagerName/singletonName
Old APIs are untouched, they will still generate the same singleton actor path akka://MyActorSystem/user/singletonName/singletonName
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #509
Changes
Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):