-
Notifications
You must be signed in to change notification settings - Fork 643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
s3: support for encryption, storage class, custom headers #254
Conversation
…aders for upload to s3
Saw that Travis build of my PR failed with an error in AwsLambdaFlowSpec and that other PRs had the same issue - anything I can do to make Travis happy? |
We're tracking that in #235, I guess someone re-triggered the build because this PR is green now. |
@kobmic I agree, the |
If it's ok to change the current API I would refactor my PR, move the params to the new S3Header case class and make them optional. What do you think? |
It makes sense to me. @johanandren WDYT? |
I agree that this is better, but could we provide a |
The compiler won't let me have multiple overloaded alternatives of method 'multipartUpload' with default arguments (which I still want in both cases). So I ended up with a 'multipartUploadWithHeaders' alternative without deprecating the old API. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Implemented server side encryption, added s3 storage class and custom headers. Fixes #109
Tried not to break the current S3Client multipartUpload API, even if I'm not to happy with always passing CannedAcl and MetaHeaders. Would be nicer to have Options for these arguments, i.e. always passing the default 'CannedAcl.Private' makes it impossible to add a custom 'x-amz-grant-read' header (conflicting).