Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest scalafmt #1778

Merged
merged 1 commit into from
Jun 26, 2019
Merged

Use latest scalafmt #1778

merged 1 commit into from
Jun 26, 2019

Conversation

2m
Copy link
Member

@2m 2m commented Jun 25, 2019

Purpose

Switches to the latest scalafmt

References

Latest scalafmt has a fix (scalameta/scalafmt#1384) for concurrent scalafmt artifact downloads. Without the fix, scalafmt might fail, if the artifacts have not been downloaded yet.

@ennru
Copy link
Member

ennru commented Jun 25, 2019

There is a new release of sbt-scalafmt https://github.com/scalameta/sbt-scalafmt/releases

@2m 2m force-pushed the wip-latest-scalafmt-2m branch from e365695 to 9b9e0a6 Compare June 25, 2019 11:45
Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But it fails to download RC8 right now.

@2m
Copy link
Member Author

2m commented Jun 26, 2019

CI validation passed.

@2m 2m merged commit 9e65558 into akka:master Jun 26, 2019
@2m 2m deleted the wip-latest-scalafmt-2m branch June 26, 2019 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants