=plugin migrate FastClasspathScanner to ClassGraph #25797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akka-ci
added
validating
|
Test PASSed. |
patriknw
reviewed
Oct 16, 2018
| .verbose() | ||
| .addClassLoader(classloader) | ||
| .scan() | ||
| val allClasses = scanner.getAllClasses.getNames.asScala.toVector |
There was a problem hiding this comment.
is it the same thing that has moved, or what is the background?
There was a problem hiding this comment.
The FastClassPathScananer is replaced by the ClassGraph, and only ClassGraph is being maintained now
|
@hepin1989 Now it prints many many when running |
|
it also seems much slower than before (perhaps due to the logging?) |
|
For me it went from an already-painful 10s to ~14s... would be great if we could speed this up somehow. |
|
The problem was |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.