Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumps ssl-config 0.3.6 #25783

Merged
merged 1 commit into from
Oct 17, 2018
Merged

Bumps ssl-config 0.3.6 #25783

merged 1 commit into from
Oct 17, 2018

Conversation

ignasi35
Copy link
Contributor

0.3.5 defaulted to PKCS12 format for the auto-generated key stores. The ssl-config library doesn't support setting the trustStore password which is required in PKCS12 format to read the trusted certificates. As a consequence generated stores could not be used as truststores.

Related to playframework/playframework#8691 and lagom/lagom#1619

@akka-ci akka-ci added validating PR is currently being validated by Jenkins tested PR that was successfully built and tested by Jenkins and removed validating PR is currently being validated by Jenkins labels Oct 11, 2018
@akka-ci
Copy link

akka-ci commented Oct 11, 2018

Test PASSed.

Copy link
Member

@patriknw patriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the daily update ;-)

@patriknw patriknw added this to the 2.5.18 milestone Oct 12, 2018
@ignasi35
Copy link
Contributor Author

LOL

The reconciliation of FakeKeyStore into ssl-config from play and lagom brought some unexpected issues. This is The One ™️ .

@patriknw patriknw merged commit 570896f into akka:master Oct 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tested PR that was successfully built and tested by Jenkins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants