bump: Akka runtime 1.4.1 #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patriknw
commented
Feb 20, 2025
| @@ -8,7 +8,7 @@ object Dependencies { | |||
| val ProtocolVersionMinor = 1 | |||
| val RuntimeImage = "gcr.io/kalix-public/kalix-runtime" | |||
| // Remember to bump kalix-runtime.version in akka-javasdk-maven/akka-javasdk-parent if bumping this | |||
| val RuntimeVersion = sys.props.getOrElse("kalix-runtime.version", "1.3.6") | |||
| val RuntimeVersion = sys.props.getOrElse("kalix-runtime.version", "1.4.0") | |||
| } | |||
| // NOTE: embedded SDK should have the AkkaVersion aligned, when updating RuntimeVersion, make sure to check | |||
There was a problem hiding this comment.
I will update the AkkaVersion, but first I want to see if CI is detecting that we haven't updated
There was a problem hiding this comment.
tried locally, and the samples will fail when we run mvn verify, so that's probably good enough
There was a problem hiding this comment.
ok, the sdk tests also fails https://github.com/akka/akka-sdk/actions/runs/13433099864/job/37529325341?pr=246
patriknw
force-pushed
the
wip-runtime-1.4.0-patriknw
branch
from
b4957b3 to
b1f82c2
Compare
|
strange, akkajavasdk.SdkIntegrationTest and ViewIntegrationTest failed, but I don't see what that could be |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.