Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add repository info #945

Merged
merged 2 commits into from
Jul 28, 2023
Merged

docs: add repository info #945

merged 2 commits into from
Jul 28, 2023

Conversation

aludwiko
Copy link
Contributor

@ennru I haven't added the repository information in all places where we use @@dependency directive. Only in cases where it makes sense from my perspective, but maybe I missed sth.

# Conflicts:
#	project/plugins.sbt
name="Akka library repository"
url="https://repo.akka.io/maven"
}

To use the R2DBC module of Akka Projections add the following dependency in your project:

@@dependency [Maven,sbt,Gradle] {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was already wrong here, should we fix it in this pr or a separate one?

Copy link
Contributor

@franciscolopezsancho franciscolopezsancho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -8,7 +8,7 @@ addSbtPlugin("com.github.sbt" % "sbt-ci-release" % "1.5.12")
addSbtPlugin("com.lightbend.akka.grpc" % "sbt-akka-grpc" % "2.3.2")

// Documentation
addSbtPlugin("com.lightbend.akka" % "sbt-paradox-akka" % "0.49")
addSbtPlugin("com.lightbend.akka" % "sbt-paradox-akka" % "0.51")
Copy link
Contributor

@franciscolopezsancho franciscolopezsancho Jul 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this? In this PR I mean.

@aludwiko aludwiko merged commit 04e520e into main Jul 28, 2023
@aludwiko aludwiko deleted the add-repository-info branch July 28, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants