Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: connection factory via R2dbcProjectionSettings.withCustomConnectionFactory #1254

Merged
merged 1 commit into from
Nov 25, 2024
Merged

feat: connection factory via R2dbcProjectionSettings.withCustomConnectionFactory #1254

merged 1 commit into from
Nov 25, 2024

Conversation

sebastian-alfers
Copy link
Contributor

No description provided.

@sebastian-alfers sebastian-alfers mentioned this pull request Nov 19, 2024
Closed
johanandren
johanandren reviewed Nov 19, 2024
View reviewed changes
Copy link
Member

@johanandren johanandren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable 👍

@sebastian-alfers sebastian-alfers marked this pull request as ready for review November 20, 2024 07:53
@sebastian-alfers sebastian-alfers merged commit a35d083 into akka:main Nov 25, 2024
21 of 22 checks passed
@patriknw
Copy link
Member

I think this PR is missing one thing. We have R2dbcSession.withSession, which is not possible to use with the custom connection factory. I think we should add

def withSession[A](system: ActorSystem[_], connectionFactory: ConnectionFactory)(
      fun: R2dbcSession => Future[A]): Future[A]

@patriknw patriknw added this to the 1.6.4 milestone Nov 26, 2024
@patriknw patriknw mentioned this pull request Nov 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanandren johanandren johanandren left review comments

@JustinPihony JustinPihony JustinPihony approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.6.4
Development

Successfully merging this pull request may close these issues.
4 participants
@sebastian-alfers @patriknw @johanandren @JustinPihony