Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: only initial backtracking up to start offset when far behind #631

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: only initial backtracking up to start offset when far behind #631

wants to merge 1 commit into from

Conversation

patriknw
Copy link
Member

@patriknw patriknw commented Dec 4, 2024

@patriknw patriknw requested a review from pvlugter December 4, 2024 07:09
@patriknw patriknw mentioned this pull request Dec 4, 2024
Merged
octonato
octonato approved these changes Dec 6, 2024
View reviewed changes
Copy link
Member

@octonato octonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@octonato
Copy link
Member

octonato commented Dec 6, 2024

But link validation is failing on https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/lang/String$.html

And indeed this page is gone.

@pvlugter
Copy link
Contributor

pvlugter commented Dec 9, 2024

Updated the link validation ignore in #633

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@octonato octonato octonato approved these changes

@pvlugter pvlugter pvlugter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@patriknw @octonato @pvlugter