feat: Skip backtracking when far behind #600
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patriknw
commented
Sep 20, 2024
core/src/main/scala/akka/persistence/r2dbc/internal/BySliceQuery.scala
Outdated
Show resolved
Hide resolved
core/src/test/scala/akka/persistence/r2dbc/query/EventsBySliceBacktrackingSpec.scala
Show resolved
Hide resolved
patriknw
commented
Sep 23, 2024
| !state.backtracking && | ||
| state.latest != TimestampOffset.Zero && | ||
| // no backtracking if far behind current wall clock time | ||
| previousTimestamp.isAfter(clock.instant().minus(firstBacktrackingQueryWindow)) && |
There was a problem hiding this comment.
I don't think it has to be more exact than this.
I have also verified that this works as expected with a sample app. Generated some 100k events test data. Ran catch up without triggering any backtracking, and then storing some new events that trigger backtracking again, and after a while backtracking stops again.
There was a problem hiding this comment.
No, there is one problem. Let's say that a projection is stopped/crashed and then isn't started immediately again. Then it should still run backtracking from the start offset (minus some) until the backtracking offset is ahead of the start offset.
patriknw
force-pushed
the
wip-heartbeat-patriknw
branch
from
1be050a to
f125c73
Compare
patriknw
force-pushed
the
wip-catchup-patriknw
branch
from
01151f8 to
b5c772b
Compare
|
Included in #614 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.