Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: correct sequence number for delete single snapshot test #579

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

pvlugter
Copy link
Contributor

@pvlugter pvlugter commented Jun 7, 2024

Noticed when reusing this test elsewhere: sequence number was incorrect, so it wasn't actually deleting a snapshot. Test still passed as successful if there's no matching snapshot. Rather than just set to the correct sequence number (15) also future proof by checking what it is before delete.

Also fix a typo in the snapshot store docs.

Verified

This commit was signed with the committer’s verified signature.
pvlugter Peter Vlugter
Copy link
Member

@patriknw patriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@patriknw patriknw added this to the 1.2.5 milestone Jun 7, 2024
@patriknw patriknw merged commit 8656aba into akka:main Jun 7, 2024
9 checks passed
@pvlugter pvlugter deleted the snapshot-store-tests branch June 7, 2024 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants