docs: clarify migration and retrieval of durable state based persistence ids #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patriknw
reviewed
Apr 11, 2024
docs/src/main/paradox/migration.md
Outdated
| @@ -74,6 +76,8 @@ The migration tool can be run as main class `akka.persistence.r2dbc.migration.Mi | |||
|
|
|||
| Durable State is not migrated by `MigrationTool.migrateAll`, instead you need to use `MigrationTool.migrateDurableStates` for a given list of persistence ids. | |||
|
|
|||
| This list can be retrieved by using `currentPersistenceIds` of @ref:[Durable state queries](./query.md#durable-state-queries). | |||
There was a problem hiding this comment.
This is misleading because you would have to retrieve them from the source (old) database, and akka-persistence-jdbc doesn't implement that query. Isn't it obvious that you can retrieve such list of persistence ids with just sql select?
There was a problem hiding this comment.
You are right, I have to remove that sentence as it was a misunderstanding.
Co-authored-by: Patrik Nordwall <[email protected]>
patriknw
reviewed
Jul 1, 2024
| @@ -9,6 +9,8 @@ idempotent result. Full rolling update when switching database or Persistence pl | |||
| you can migrate most of the data while the system is online and then have a short full shutdown while | |||
| migrating the remaining data that was written after the previous online migration. | |||
|
|
|||
| The migration tool is intended to run as a separate, standalone application and should not be part of the same jvm process as the main application is running under. | |||
There was a problem hiding this comment.
@sebastian-alfers Is this PR ready?
patriknw
approved these changes
Jul 1, 2024
|
Flaky SQL Server test, but ignoring that since this is clearly just a doc addition |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.