Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Native-image support #529

Merged
merged 6 commits into from
Feb 28, 2024
Merged

feat: Native-image support #529

merged 6 commits into from
Feb 28, 2024

Conversation

johanandren
Copy link
Member

No description provided.

Copy link
Member

@patriknw patriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good

Copy link
Member

@patriknw patriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good

docs/src/main/paradox/native-image.md Outdated Show resolved Hide resolved
Comment on lines 21 to 20
// FIXME why doesn't @JsonCreator work as usual? is it something missing from the jackson feature?
final case class GetState @JsonCreator() (replyTo: ActorRef[State]) extends Command
final case class GetState(replyTo: ActorRef[State]) extends Command
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 great that it works out-of-the-box now

@johanandren
Copy link
Member Author

@johanandren johanandren marked this pull request as ready for review February 27, 2024 16:49
Copy link
Contributor

@pvlugter pvlugter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@patriknw patriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johanandren johanandren merged commit c6586b4 into main Feb 28, 2024
10 checks passed
@johanandren johanandren deleted the wip-native-image-support branch February 28, 2024 08:24
@johanandren johanandren added this to the 1.2.3 milestone Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants