feat: migration for sqlserver #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastian-alfers
changed the title
patriknw
reviewed
Feb 5, 2024
|
|
||
| override protected def log: Logger = SqlServerMigrationToolDao.log | ||
|
|
||
| override protected implicit def queryAdapter: QueryAdapter = SqlServerQueryAdapter |
There was a problem hiding this comment.
is this used? you have imported Sql.Interpolation, which is without the adapter. Maybe best that we use Sql.InterpolationWithAdapter everywhere in this project?
There was a problem hiding this comment.
is this used?
No. In fact, I hadn't rebased on main - which I have done now so this is gone.
Maybe best that we use
Sql.InterpolationWithAdaptereverywhere in this project?
Yes, let me change it.
sebastian-alfers
force-pushed
the
sqlserver-migration-2nd
branch
from
a86caba to
62f7f23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #509