Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid failing when running with testOnly mode #492

Merged
merged 2 commits into from
Dec 18, 2023
Merged

fix: avoid failing when running with testOnly mode #492

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a6b749
fix: avoid failing when running with testOnly mode
sebastian-alfers Dec 18, 2023
fca7165
no sorting, fix generating of entity types
sebastian-alfers Dec 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/src/test/scala/akka/persistence/r2dbc/query/CurrentPersistenceIdsQuerySpec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ class CurrentPersistenceIdsQuerySpec
"Event Sourced currentPersistenceIds" should {
"retrieve all ids" in {
val result = query.currentPersistenceIds().runWith(Sink.seq).futureValue
result shouldBe pids.map(_.id)
result shouldBe pids.map(_.id).sorted
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same problem for the other tests in this Spec? I think you can add a sort at the val pids instead

val pids .... .sortBy(_.id)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I though the same initially (val pids = ... .sortBy(_.id)). But when doing that, another spec fails in that file (retrieve ids for entity type after id) so I kept it in this single place where all seems to pass fine 🤷

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alright, the problem is the usage of nextEntityType, since for example EntityType-9 is sorted after Entitytype-10, so it depends on where the counter starts at. I think that since this test depends on sorting being the same as in the db it's best to not use that nextEntityType here. Instead, create them as:

private val entityTypes = (1 to numberOfEntityTypes).map(n => "Entity" + zeros.drop(n.toString.length) + n)

Then no further sorting should be needed.

}

"retrieve ids after id" in {
Expand Down