Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Envelope source is different for durable state #464

Merged
merged 1 commit into from
Oct 3, 2023
Merged

fix: Envelope source is different for durable state #464

merged 1 commit into from
Oct 3, 2023

Conversation

patriknw
Copy link
Member

@patriknw patriknw commented Oct 3, 2023

  • NullPointerException in isPayloadDefined
  • regression when adding the starting from snapshots, i.e. this bug was not released in any final version (but in milestones)
  • for durable state we use null payload as the backtracking marker in the row, becuse we also have the deleted case, ugly but that goes all the way to Akka's UpdatedDurableState

@patriknw
fix: Envelope source is different for durable state
db6e2f4 
* NullPointerException in isPayloadDefined
* regression when adding the starting from snapshots, i.e.
  this bug was not released in any final version (but in milestones)
* for durable state we use null payload as the backtracking marker
  in the row, becuse we also have the deleted case, ugly but that goes all the
  way to Akka's UpdatedDurableState
@patriknw patriknw added the bug Something isn't working label Oct 3, 2023
patriknw
patriknw commented Oct 3, 2023
View reviewed changes
core/src/main/scala/akka/persistence/r2dbc/internal/BySliceQuery.scala
@@ -459,8 +458,7 @@ import org.slf4j.Logger
behindCurrentTime,
backtracking = newState.backtracking)
.filter { row =>
val source = if (row.isPayloadDefined) EnvelopeOrigin.SourceQuery else EnvelopeOrigin.SourceBacktracking
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the NPE was here

@johanandren johanandren merged commit 2456b04 into main Oct 3, 2023
6 checks passed
@johanandren johanandren deleted the wip-null-payload-patriknw branch October 3, 2023 15:43
@johanandren johanandren added this to the 1.2.0-M6 milestone Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanandren johanandren johanandren approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
1.2.0-M6
Development

Successfully merging this pull request may close these issues.
2 participants
@patriknw @johanandren