scala 3: compile and test marshalling, JMH and docs subprojects #4126
Conversation
| @@ -69,7 +70,7 @@ object HttpServerWithActorInteraction { | |||
| implicit val timeout: Timeout = 5.seconds | |||
|
|
|||
| // query the actor for the current auction state | |||
| val bids: Future[Bids] = (auction ? GetBids).mapTo[Bids] | |||
| val bids: Future[Bids] = (auction ? (replyTo => GetBids(replyTo))).mapTo[Bids] | |||
There was a problem hiding this comment.
With a typed actor I'd expected being able to do val bids: Future[Bids] = action ? (GetBids(_)) (or ask instead of ? which makes the param list parenthesis's more obvious), without needing the mapTo at all.
| @@ -143,7 +144,7 @@ class MiscDirectivesExamplesSpec extends RoutingSpec with CompileOnlySpec { | |||
|
|
|||
| // tests: | |||
| def entityOfSize(size: Int) = | |||
| HttpEntity(ContentTypes.`text/plain(UTF-8)`, "0" * size) | |||
| HttpEntity(ContentTypes.`text/plain(UTF-8)`, List.fill(size)('0').mkString) | |||
There was a problem hiding this comment.
That's true. Unfortunately "0" * size somehow picks up the * from PathMatchers instead of from StringOps. Since this is just a test I didn't think it's that big of a deal - do you have a nicer way to create an entity of a given size?
Three errors around parameters remaining
raboof
force-pushed
the
scala-3-compile-jmh-and-docs
branch
from
4f47923 to
1191ed8
Compare
raboof
changed the title
| @@ -69,7 +70,7 @@ object HttpServerWithActorInteraction { | |||
| implicit val timeout: Timeout = 5.seconds | |||
|
|
|||
| // query the actor for the current auction state | |||
| val bids: Future[Bids] = (auction ? GetBids).mapTo[Bids] | |||
| val bids: Future[Bids] = (auction ? (replyTo => GetBids(replyTo))).mapTo[Bids] | |||
There was a problem hiding this comment.
With a typed actor I'd expected being able to do val bids: Future[Bids] = action ? (GetBids(_)) (or ask instead of ? which makes the param list parenthesis's more obvious), without needing the mapTo at all.
On top of #4079
Three errors remaining around creating case classes from parameters