Scala 3: edit sources on-the-fly in sbt to support @pre213 methods in shared source code
#4113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in Scala 3 easily" This reverts commit 10b7d4a.
22 tasks
jrudolph
commented
Apr 25, 2022
| object Pre213Preprocessor extends AutoPlugin { | ||
| val pre213Files = settingKey[Seq[String]]("files that should be edited for pre213 annotation") | ||
|
|
||
| val pattern = """(?s)@pre213.*?@since213""".r |
There was a problem hiding this comment.
Yes, we've come a far way from (only) running regex on URLs...
jrudolph
changed the title
@pre213 methods in shared source code@pre213 methods in shared source code
To verify that we have nothing broken so far
|
Let's merge this even if this pattern will ultimately be removed for 10.3.x. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(But hopefully get soon rid of it when we drop Scala 2.12 support)
Only applied to akka-http-core so far.