-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add setting ignore-illegal-header-for #687 #1942
Merged
ktoso
merged 18 commits into
akka:master
from
shnmorimoto:feat_add_setting_ignore_illegal_header_for
May 7, 2018
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
9af1505
add setting ignore-illegal-header-for #687
563ddc2
fix binary incompatibility #687
b9b45d7
move binary compatibility warning configuration to 10.1.0 #687
2185245
add setting's comment #687
0e970a3
rename method #687
2aba588
reorder method #687
9ec538b
check ignore header name insensitive #687
bc2e09e
Update 10.1.0.backwards.excludes
ktoso 8b14a92
put case class back for ErrorInfo. and add annotation @InternalAPI #687
1e5a325
fix test #687
f577046
delete InternalApi annnotation from ErrorInfo #687
a9585d4
create 10.1.2.backwards.excludes #687
48954f0
Chainge ErrorInfo from caseclass to class for bin incomp #687
8c04d0c
Update reference.conf
ktoso 0d01b92
add tests #687
8e82d9b
use parseLine #687
shnmorimoto 1579427
Update reference.conf
ktoso edf0180
Merge branch 'master' into feat_add_setting_ignore_illegal_header_for
ktoso File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
6 changes: 6 additions & 0 deletions
6
akka-http-core/src/main/mima-filters/10.1.2.backwards.excludes
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
# Don't monitor changes to internal API | ||
ProblemFilters.exclude[Problem]("akka.http.impl.*") | ||
|
||
# #1942 New ignoreIllegalHeaderFor setting | ||
ProblemFilters.exclude[ReversedMissingMethodProblem]("akka.http.javadsl.settings.ParserSettings.getIgnoreIllegalHeaderFor") | ||
ProblemFilters.exclude[ReversedMissingMethodProblem]("akka.http.scaladsl.settings.ParserSettings.ignoreIllegalHeaderFor") |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please leave it as a
case class
, no reason to change IMHO; we should mark it as@InternalApi
perhaps evenThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your review.
I put case class back. and add annotation
@InternalAPI
as described below.I check binary compatible with
mimaReportBinaryIssues
sbt command.I still receive a following error log.
Should I add three method(copy, this, apply) to the mima-filters configuration?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the check fail is expected and yes it should be added to the excludes :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
akka-http-core/src/main/mima-filters/10.1.0.backwards.excludes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I understand.
I put case class back. And add some methods to 10.1.0.backwards.excludes.