remove isGrpcRequest check from the java api to align with scala api #1669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(but let's wait to see what @raboof thinks before merging) |
raboof
approved these changes
Aug 26, 2022
| @@ -50,7 +49,7 @@ object ServiceHandler { | |||
| def handler(handlers: JFunction[HttpRequest, CompletionStage[HttpResponse]]*) | |||
| : JFunction[HttpRequest, CompletionStage[HttpResponse]] = { | |||
| val servicesHandler = concat(handlers: _*) | |||
| (req: HttpRequest) => if (sServiceHandler.isGrpcRequest(req)) servicesHandler(req) else unsupportedMediaType | |||
| (req: HttpRequest) => servicesHandler(req) | |||
There was a problem hiding this comment.
The comment says "If the request is for an invalid media type, then a 415: Unsupported Media Type response is produced.". This probably only is true for paths matched by the handler? Might be something to double-check and perhaps make the comment more specific?
There was a problem hiding this comment.
Good point, I changed the comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1668 and #1574