Use flat_package for scala codegen by default #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2m
reviewed
Mar 19, 2018
project/ReflectiveCodeGen.scala
Outdated
| "single_line_to_string" -> false).collect { case (settingName, v) if v => settingName } | ||
|
|
||
| MutableGeneratorAccess(adapted.setUnderlying _, (generator, settings)) | ||
| MutableGeneratorAccess(adapted.setUnderlying _, (JvmGenerator(s"mutable", adapted), codeGeneratorSettings)) |
2m
reviewed
Mar 19, 2018
| // that are more consistent between Scala and Java. | ||
| // Because the interop tests generate both Scala and Java code, however, here we disable this | ||
| // option to avoid name clashes in the generated classes: | ||
| (codeGeneratorSettings in Compile) := Seq.empty |
There was a problem hiding this comment.
Maybe use (codeGeneratorSettings in Compile).value.filterNot(_ == "flat_package") in case we have other settings by default?
There was a problem hiding this comment.
👍 not super nice to have this stringly-typed but most flexible and not really worth adding infrastructure for I suppose.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #82