Skip to content

Commit

Permalink
scsi: core: fix scsi_host_queue_ready
Browse files Browse the repository at this point in the history
3287286 ("scsi: avoid to hold host-wide counter of host_busy for
scsi_mq") adds one extra check on scsi_host_busy(shost) in
scsi_host_queue_ready(), which is wrong and not necessary, can causes
booting stall on LSI53c895A.

So remove the check.

Cc: Omar Sandoval <[email protected]>,
Cc: "Martin K. Petersen" <[email protected]>,
Cc: James Bottomley <[email protected]>,
Cc: Christoph Hellwig <[email protected]>,
Cc: Don Brace <[email protected]>
Cc: Kashyap Desai <[email protected]>
Cc: Mike Snitzer <[email protected]>
Cc: Hannes Reinecke <[email protected]>
Cc: Laurence Oberman <[email protected]>
Cc: Bart Van Assche <[email protected]>
Cc: Guenter Roeck <[email protected]>
Reported-by: Guenter Roeck <[email protected]>
Fixes: 3287286 ("scsi: avoid to hold host-wide counter of host_busy for scsi_mq")
Signed-off-by: Ming Lei <[email protected]>
Tested-by: Guenter Roeck <[email protected]>
Signed-off-by: Martin K. Petersen <[email protected]>
  • Loading branch information
Ming Lei authored and martinkpetersen committed Jul 2, 2018
1 parent 624fa77 commit 265d59a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/scsi/scsi_lib.c
Original file line number Diff line number Diff line change
Expand Up @@ -1611,7 +1611,7 @@ static inline int scsi_host_queue_ready(struct request_queue *q,
else
busy = 0;
if (atomic_read(&shost->host_blocked) > 0) {
if (busy || scsi_host_busy(shost))
if (busy)
goto starved;

/*
Expand Down

0 comments on commit 265d59a

Please sign in to comment.