Finite variable width slider slides always fill the display area #1337
Conversation
This way you avoid having a right blank padding when getting to the last elements and they don't fill up the entire gallery. See [issue akiran#1334](akiran#1334)
There were inconsistencies between the changelog and the actual tags applied.
|
This is nice @diegopamio! Please consider the case when there are few items in the carousel. I can see a bug in this case where the few items (in this case just 2) get aligned to the right instead of left as they are supposed to! See GIF: |
They are not needed, only the non infinite scroll mode.
…hort Snapping to the right never should make the list to have left padding, for instance when the list of images in the gallery doesn't fill up the entire window.
and adds release change log.
|
@cgadam done, now it doesn't snap to the right if the width of all the available images is less than the width of the container. |
There was a problem hiding this comment.
@diegopamio Hey, thanks for the effort! One more thing:
Although this really removes the right padding, when you reach the end you still allow the "next" arrow to be clickable, which shouldn't be the case.
https://codesandbox.io/s/6l4wpv0q8z
|
What is the status of this PR? @diegopamio |
|
Yeah I agree with @precompiled! This needs to be resolved too :/ |
|
Will it be merged? |
|
Will it be merged one day ? 🙏 @akiran |
|
I'm having little to nothing free time for this, If anyone can help on @precompiled request, or if we can do it separately, I can collaborate. |
|
I've finally switched to swiper. Thanks ! |
|
@diegopamio, Hi! I faced the same problem that this PR solves, and wouldn't mind to finish your job. Could you add me to collaborators of the fork so I could add commits here? |
Fixes #1334
I've added some logic to snap the right side of the last slide to the right side of the scrolling window.