Skip to content

Commit

Permalink
Rollback lines added as these lines cannot be reached now
Browse files Browse the repository at this point in the history
Fix for line#4625 .
  • Loading branch information
aki-s committed Mar 8, 2023
1 parent c9a2c02 commit 03672a9
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 8 deletions.
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright 2023 LINE Corporation
* Copyright 2017 LINE Corporation
*
* LINE Corporation licenses this file to you under the Apache License,
* version 2.0 (the "License"); you may not use this file except in compliance
Expand Down Expand Up @@ -218,11 +218,6 @@ void doClose(Status status, Metadata metadata, boolean completed) {
if (res.tryWrite(responseTrailers(ctx, status, metadata, trailersOnly))) {
res.close();
}
} catch (Exception e) {
ctx.logBuilder().endResponse(e);
if (res.isOpen()) {
res.close(e);
}
} finally {
closeListener(statusAndMetadata, completed, false);
}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright 2023 LINE Corporation
* Copyright 2017 LINE Corporation
*
* LINE Corporation licenses this file to you under the Apache License,
* version 2.0 (the "License"); you may not use this file except in compliance
Expand Down Expand Up @@ -172,7 +172,6 @@ void doClose(Status status, Metadata metadata, boolean completed) {
ctx.logBuilder().responseContent(GrpcLogUtil.rpcResponse(statusAndMetadata, responseMessage), null);
resFuture.complete(response);
} catch (Exception ex) {
ctx.logBuilder().endResponse(ex);
resFuture.completeExceptionally(ex);
} finally {
closeListener(statusAndMetadata, completed, false);
Expand Down

0 comments on commit 03672a9

Please sign in to comment.