Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate docs #1

Merged
merged 18 commits into from
Jan 21, 2025
Merged

Automate docs #1

merged 18 commits into from
Jan 21, 2025

Conversation

ssolson
Copy link

@ssolson ssolson commented Jan 15, 2025

Documentation Build System Updates

Major Changes

  • Automated documentation builds using GitHub Actions
  • Documentation is now automatically deployed to GitHub Pages when changes are pushed to main branch
  • Removed built documentation files from repository in favor of automated builds

Technical Details

New Files Added

  • .github/workflows/docs.yml - GitHub Actions workflow for automated builds
  • environment.yml - Conda environment specification for reproducible builds

Configuration Updates

  • Added documentation build patterns to .gitignore
  • Updated GitHub Pages configuration to serve from gh-pages branch root (need to update MHKiT docs repo on PR merge)
  • Added .nojekyll file to support underscore-prefixed directories

Build Process

  • Documentation is now built using Sphinx in a controlled conda environment
  • Build process includes:
    • Python 3.10
    • Sphinx 8.1.3
    • All required Sphinx extensions (bibtex, matlabdomain, rtd theme, etc.)
    • Automatic submodule initialization

Deployment

  • Built documentation is automatically deployed to GitHub Pages
  • Deployment occurs on pushes to main branch
  • Preview builds available for pull requests

Benefits

  • Consistent build environment across all contributors
  • Automated deployment reduces manual steps
  • Cleaner repository without built files
  • Easier contribution process for documentation updates

Local Development

Contributors can still build documentation locally using:

conda env create -f environment.yml
conda activate mhkit-docs
cd docs
make html

@ssolson ssolson marked this pull request as ready for review January 15, 2025 22:38
Copy link
Owner

@akeeste akeeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ssolson Thanks for updating this process. A couple minor comments on how these updates mesh with a couple commits already on this branch

README.md Outdated Show resolved Hide resolved
.github/workflows/docs.yml Outdated Show resolved Hide resolved
environment.yml Show resolved Hide resolved
Copy link
Author

@ssolson ssolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great review Adam. I believe I have addressed you concerns. lmk!

environment.yml Show resolved Hide resolved
.github/workflows/docs.yml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@akeeste
Copy link
Owner

akeeste commented Jan 21, 2025

Looks good now, thanks @ssolson

@akeeste akeeste self-requested a review January 21, 2025 19:55
@akeeste akeeste merged commit 39335d7 into akeeste:automate_docs Jan 21, 2025
@ssolson ssolson deleted the automate_docs branch February 4, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants