Pacwave Notebook fixes & Tidal Test fixes #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssolson
changed the title
|
@akeeste this should be good to go and fix the breaking tests on MHKiT-Software#327 |
12 tasks
akeeste
approved these changes
May 22, 2024
|
Great, thanks @ssolson |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will fix the Pacwave notebook & the failing tidal tests on MHKiT-Software#327
The last PR was merged before I added the Pacwave fixes.
This will make the map work and I use an inline calculation on Tp to take the cell computation time from +30 min to 9 min.
We need to resolve the performance issues with xarray in a follow on PR.