Support multiple startPoints at AMFlow#put(get)StartPoint() #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yu-ogi
commented
Jan 31, 2019
| this.startPoints.filter(s => s.timestamp <= opts.timestamp).sort((a, b) => (a.timestamp < b.timestamp ? 1 : -1))[0] || null | ||
| ); | ||
| } | ||
| return this.startPoints.find(s => s.frame === 0) || null; |
There was a problem hiding this comment.
https://github.com/akashic-games/amflow/blob/b06ed86fadc82f639c3cee834d555d3e14a8ac13/src/AMFlow.ts
以下の定義に従って開始地点情報を取得します。
- オプションとしてフレーム番号もタイムスタンプも指定しない場合は、0フレーム目の開始地点情報を取得する。
- オプションを指定した場合は、条件を満たすの直近の開始地点情報を取得する。
frameまたはtimestampがしていされた場合、その値よりも小さい内で最大のframeまたはtimestampを持つ開始地点情報を取得する。frameとtimestampと同時に指定された場合、動作は不定である。
- に関しては、本実装では
frameの値を優先して参照します。
xnv
requested changes
Jan 31, 2019
yu-ogi
commented
Jan 31, 2019
xnv
requested changes
Feb 1, 2019
xnv
approved these changes
Feb 1, 2019
dera-
approved these changes
Feb 4, 2019
dera-
reviewed
Feb 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
このPullRequestが解決する内容
AMFlow の仕様に合わせて
AMFLowStoreの実装を修正します。