fix: handle non-zero startpoints in PlayManager#createPlay() #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xnv
commented
Sep 6, 2021
Comment on lines
-89
to
91
| setTickList(tickList: TickList): void { | ||
| setTickList(tickList: TickList | null): void { | ||
| this.store.setTickList(tickList); | ||
| } |
There was a problem hiding this comment.
- このメソッドはなくしていいような気もしますが、
PlayManager経由でこのクラスは外部に露出するようなので破壊的変更を避けています。 nullを許容しているのは型上のつじつま合わせですが、空にリセットする能力を持つことはは変ではないはず。
xnv
commented
Sep 6, 2021
| this.store.setTickList(tickList); | ||
| } | ||
|
|
||
| setDumpedPlaylog(dumped: DumpedPlaylog): void { |
There was a problem hiding this comment.
setTickListとの対称を考えるとsetStartPointsの方が座りがいいかもしれませんが、そもそも独立に扱うことの方が奇妙 (tickList を維持したまま startPoints だけ設定するようなケースがあるとは思えない) ので、DumpedPlaylogを受けています。- 名前の座りが悪いんですが、たとえば
reset()では誇張があり (authenticate の状況などはリセットされない) 採用できませんでした。
yu-ogi
approved these changes
Sep 7, 2021
kamakiri01
approved these changes
Sep 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
掲題どおり。
第 0 startPoint 以外の start point が無視されていたのを修正します。
テストがなかったので加えます。