Refactor AMFlowClient #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yu-ogi
commented
Mar 29, 2019
| .then(() => { | ||
| activeAMFlow.open(playId); | ||
| passiveAMFlow.open(playId); | ||
| }) |
There was a problem hiding this comment.
上ですでに open していたので無駄な呼び出しでした。
yu-ogi
commented
Mar 29, 2019
| @@ -422,6 +427,91 @@ describe("AMFlow の動作テスト", () => { | |||
| }); | |||
| }); | |||
| }); | |||
|
|
|||
| it("AMFlow#onEvent が登録されるより以前の Event を正しく取得できる", done => { | |||
yu-ogi
commented
Mar 29, 2019
| @@ -248,6 +249,7 @@ describe("run-test", () => { | |||
| if (err) { | |||
| assert.equal(err instanceof Error, true); | |||
| assert.equal(permission == null, true); | |||
| assert.strictEqual(err.name, "InvalidStatus"); | |||
yu-ogi
commented
Mar 29, 2019
| .then(() => { | ||
| return new Promise((resolve, reject) => { | ||
| // すでに stop したプレーの AMFlowClient に対して close() を呼び出しても問題ない | ||
| passiveAMFlow.close(err => (err ? reject(err) : resolve())); |
xnv
approved these changes
Mar 29, 2019
| if (!this.store.isDestroyed()) { | ||
| this.store.sendEventTrigger.remove(this.onEventSended, this); | ||
| this.store.sendTickTrigger.remove(this.onTickSended, this); | ||
| } | ||
| this.store = null; |
dera-
approved these changes
Apr 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
このPullRequestが解決する内容
AMFlowClient をリファクタリングします。
Error#nameを定義に合わせるAMFlowClient#close()を呼んだ際にエラーが発生していた件の修正