feat(availability-bar): improve availability bar dot color generation to follow logical UX/UI rules #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on file availability-bar.tsx
rianfloo
changed the title
rianfloo
changed the title
rianfloo
changed the title
rianfloo
changed the title
|
@aktdenis what are your thoughts on this. |
|
@HoomanDgtl agree with @rianfloo. @rianfloo it's something we've considered and talked about in the past. thank you for contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This update refines the dot generation logic in the file availability-bar.tsx component to enhance the user experience by clearly representing GPU availability and usage.
Key Updates
• White Dots: Represent the amount of GPU available.
• Transparent Dots: Represent the amount of GPU currently rented.
Context and Reasoning
According to UI guidelines, a transparent or disabled state is typically used to represent something that is out of stock or unavailable. Using a white dot to indicate available GPUs aligns with this convention, reinforcing the expectation that these resources are available for allocation. This approach enhances both consistency and user understanding.
Before
After
