Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: composite keys initial utils #193

Merged
merged 1 commit into from
May 21, 2018
Merged

types: composite keys initial utils #193

merged 1 commit into from
May 21, 2018

Conversation

boz
Copy link
Contributor

@boz boz commented May 18, 2018

Initial work on handling composite keys decently.

refs #77

Initial work on handling composite keys decently.

refs #77
@boz boz requested a review from aastein as a code owner May 18, 2018 20:36
@coveralls
Copy link

Pull Request Test Coverage Report for Build 356

  • 395 of 515 (76.7%) changed or added relevant lines in 22 files are covered.
  • 7 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.6%) to 65.513%

Changes Missing Coverage Covered Lines Changed/Added Lines %
app/deployment/app.go 15 16 93.75%
app/fulfillment/app.go 9 10 90.0%
app/order/app.go 12 13 92.31%
cmd/akash/deployment.go 0 2 0.0%
cmd/akash/marketplace.go 0 2 0.0%
app/provider/app.go 1 4 25.0%
app/lease/app.go 19 31 61.29%
types/id.go 42 54 77.78%
keys/parse.go 51 67 76.12%
state/fulfillment.go 31 48 64.58%
Files with Coverage Reduction New Missed Lines %
cmd/akash/provider.go 1 44.68%
state/adapter.go 2 74.07%
app/deployment/app.go 4 51.14%
Totals Coverage Status
Change from base Build 353: 0.6%
Covered Lines: 3767
Relevant Lines: 5750

💛 - Coveralls

@nalesandro nalesandro merged commit 0ddc681 into master May 21, 2018
@nalesandro nalesandro deleted the keyid branch May 21, 2018 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants