Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update closing/closed state logic #167

Merged
merged 3 commits into from
Apr 2, 2018
Merged

update closing/closed state logic #167

merged 3 commits into from
Apr 2, 2018

Conversation

aastein
Copy link
Contributor

@aastein aastein commented Mar 30, 2018

fixes: #162
refs: #143

changes:

  • On TxCloseDeployment orders and fulfillment should be set to CLOSED.
  • Orders and fulfillments should not have a CLOSING state.
  • The market engine should not send TxDeploymentClosed.
  • The provider should send TxDeploymentClosed.
  • TxDeploymentClosed rename to TxLeaseClosed and is per lease
  • The TxLeaseClosed is valid if sent by the lease provider
  • The deployment is CLOSED once all leases are CLOSED
  • Query active leases for deployment
  • update dot diagram
  • if no active leases set deployment and groups to closed

questions:

  • also set deployment and groups to CLOSED on TxCloseDeployment

@aastein aastein requested a review from boz as a code owner March 30, 2018 23:18
@coveralls
Copy link

Pull Request Test Coverage Report for Build 218

  • 89 of 417 (21.34%) changed or added relevant lines in 17 files are covered.
  • 11 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-2.9%) to 61.932%

Changes Missing Coverage Covered Lines Changed/Added Lines %
cmd/akash/marketplace.go 0 4 0.0%
app/order/app.go 1 6 16.67%
app/deployment/app.go 25 33 75.76%
cmd/akash/query/lease.go 0 11 0.0%
testutil/lease.go 0 21 0.0%
cmd/akash/deployment.go 0 22 0.0%
cmd/akash/provider.go 0 37 0.0%
app/lease/app.go 7 227 3.08%
Files with Coverage Reduction New Missed Lines %
app/deployment/app.go 1 52.59%
app/lease/app.go 1 23.41%
cmd/akash/provider.go 1 30.32%
state/lease.go 8 76.27%
Totals Coverage Status
Change from base Build 215: -2.9%
Covered Lines: 3096
Relevant Lines: 4999

💛 - Coveralls

Copy link
Contributor

@boz boz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks great

@aastein aastein changed the title Dep close update closing/closed state logic Apr 2, 2018
@aastein aastein merged commit dad544b into master Apr 2, 2018
@aastein aastein deleted the dep-close branch April 2, 2018 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update closing/closed state logic
3 participants