Dosable addr #165
Merged
Dosable addr #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aastein
commented
Mar 29, 2018
| repeated ProviderAttribute requirements = 1 [(gogoproto.nullable) = false]; | ||
| repeated ResourceGroup resources = 2 [(gogoproto.nullable) = false]; | ||
| } | ||
|
|
There was a problem hiding this comment.
any name suggestions for this?
Pull Request Test Coverage Report for Build 214
💛 - Coveralls |
boz
approved these changes
Mar 29, 2018
| /* begin stub data */ | ||
| deployment := testutil.Deployment(tenant, nonce) | ||
| groups := testutil.DeploymentGroups(deployment.Address, nonce) | ||
| groups := testutil.DeploymentGroups(*new(base.Bytes), nonce) |
There was a problem hiding this comment.
testutil.DeploymentAddress(t) if you want.
cmd/akash/deployment.go
Outdated
| l := tx.Lease | ||
| fmt.Printf("Group %v/%v Lease: %X\n", l.Group, len(groups.GetItems()), | ||
| fmt.Printf("Group %v/%v Lease: %X\n", l.Group, len(groups), |
There was a problem hiding this comment.
hmm not sure how how did %X got back in there. use "%v",X(state.FulfillmentID(...))) for these.
| // todo: read and parse deployment yaml file | ||
|
|
||
| /* begin stub data */ | ||
| provider := testutil.Provider(tenant, nonce) | ||
| provider := testutil.Provider(*new(base.Bytes), nonce) |
| repeated ProviderAttribute requirements = 1 [(gogoproto.nullable) = false]; | ||
| repeated ResourceGroup resources = 2 [(gogoproto.nullable) = false]; | ||
| } | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #79
refs #164