Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/akash cleanup: use context.Client() #156

Merged
merged 2 commits into from
Mar 27, 2018
Merged

cmd/akash cleanup: use context.Client() #156

merged 2 commits into from
Mar 27, 2018

Conversation

boz
Copy link
Contributor

@boz boz commented Mar 27, 2018

No description provided.

@boz boz requested a review from aastein as a code owner March 27, 2018 22:09
@coveralls
Copy link

coveralls commented Mar 27, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 137

  • 5 of 8 (62.5%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 66.225%
Changes Missing Coverage Covered Lines Changed/Added Lines %
cmd/akash/provider.go 0 1 0.0%
testutil/shrug.go 1 3 33.33%
Totals Coverage Status
Change from base Build 129: 0.03%
Covered Lines: 3149
Relevant Lines: 4755
💛 - Coveralls

@boz
Copy link
Contributor Author

boz commented Mar 27, 2018

bit by #124

aastein
aastein approved these changes Mar 27, 2018
View reviewed changes
Copy link
Contributor

@aastein aastein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮

@boz boz force-pushed the use-ctx-methods branch 3 times, most recently from 1b475a4 to 668c462 Compare March 27, 2018 22:57
@boz boz force-pushed the use-ctx-methods branch from 668c462 to 7df17c6 Compare March 27, 2018 22:58
@boz boz force-pushed the use-ctx-methods branch from 7df17c6 to d219606 Compare March 27, 2018 22:58
@boz boz merged commit d219606 into master Mar 27, 2018
@boz boz deleted the use-ctx-methods branch March 27, 2018 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aastein aastein aastein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@boz @coveralls @aastein