remove nullable goproto option for DeploymentGroups (#149)

* remove nullable

* remove assign by index

app/deployment/app.go

@@ -385,7 +385,7 @@ func (a *app) doDeliverCreateTx(ctx apptypes.Context, tx *types.TxCreateDeployme
 	for _, group := range groups {
 		group.Deployment = deployment.Address
 		group.Seq = seq.Advance()
-		a.State().DeploymentGroup().Save(&group)
+		a.State().DeploymentGroup().Save(group)
 	}
 
 	if err := a.State().Deployment().Save(deployment); err != nil {
@@ -440,11 +440,10 @@ func (a *app) doDeliverCloseTx(ctx apptypes.Context, tx *types.TxCloseDeployment
 
 	deployment.State = types.Deployment_CLOSING
 
-	for i, group := range groups {
+	for _, group := range groups {
 		// begin for each group
 		if group.State != types.DeploymentGroup_CLOSING {
 			group.State = types.DeploymentGroup_CLOSING
-			groups[i] = group
 		}
 
 		orders, err := a.State().Order().ForGroup(group)
@@ -575,11 +574,10 @@ func (a *app) doDeliverClosedTx(ctx apptypes.Context, tx *types.TxDeploymentClos
 		}
 	}
 
-	for i, group := range groups {
+	for _, group := range groups {
 		// begin for each group
 		if group.State != types.DeploymentGroup_CLOSED {
 			group.State = types.DeploymentGroup_CLOSED
-			groups[i] = group
 		}
 
 		orders, err := a.State().Order().ForGroup(group)

app/market/engine_test.go

@@ -19,7 +19,7 @@ func TestEngine_Orders(t *testing.T) {
 	require.NoError(t, state_.Deployment().Save(deployment))
 
 	for idx := range groups.GetItems() {
-		require.NoError(t, state_.DeploymentGroup().Save(&groups.GetItems()[idx]))
+		require.NoError(t, state_.DeploymentGroup().Save(groups.GetItems()[idx]))
 	}
 
 	txs, err := market.NewEngine(testutil.Logger()).Run(state_)

app/order/app_test.go

@@ -62,7 +62,7 @@ func TestTx(t *testing.T) {
 	orderSeq := uint64(0)
 	testutil.CreateOrder(t, app, account, &key, deployment.Address, groups.GetItems()[0].Seq, orderSeq)
 
-	orders, err := state_.Order().ForGroup(&groups.GetItems()[0])
+	orders, err := state_.Order().ForGroup(groups.GetItems()[0])
 	require.NoError(t, err)
 	require.Len(t, orders, 1)
 

testutil/deployment.go

@@ -135,7 +135,7 @@ func DeploymentGroups(deployment base.Bytes, nonce uint64) *types.DeploymentGrou
 		OrderTTL:     orderTTL,
 	}
 
-	groups := []types.DeploymentGroup{*group}
+	groups := []*types.DeploymentGroup{group}
 
 	return &types.DeploymentGroups{Items: groups}
 }

types/types.proto

@@ -124,7 +124,7 @@ message DeploymentGroup {
 }
 
 message DeploymentGroups {
-  repeated DeploymentGroup items = 1 [(gogoproto.nullable) = false];
+  repeated DeploymentGroup items = 1;
 }
 
 message Deployment {