Skip to content

Commit

Permalink
akash-ingress: disable nodePorts + fix helm linter (#83)
Browse files Browse the repository at this point in the history
* akash-ingress: disable nodePorts

we already expose the ports via hostPorts in the daemonset, so there is no reason
allocating the same ports via nodePorts.

* fix helm linter

* address all helm linter errors
  • Loading branch information
andy108369 authored Jul 5, 2022
1 parent 513ac2a commit 621e584
Show file tree
Hide file tree
Showing 7 changed files with 27 additions and 28 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/lint-helm.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,11 @@ jobs:
- name: Run chart-testing (list-changed)
id: list-changed
run: |
changed=$(ct list-changed --target-branch $GITHUB_HEAD_REF)
changed=$(ct list-changed --target-branch ${{ github.event.repository.default_branch }})
if [[ -n "$changed" ]]; then
echo "::set-output name=changed::true"
fi
- name: Run chart-testing (lint)
run: ct lint --target-branch $GITHUB_HEAD_REF
run: ct lint --target-branch ${{ github.event.repository.default_branch }} --validate-maintainers=false

2 changes: 1 addition & 1 deletion charts/akash-ingress/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.20.0
version: 0.21.0

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
Expand Down
4 changes: 2 additions & 2 deletions charts/akash-ingress/templates/controller-service.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ metadata:
name: ingress-nginx-controller
namespace: ingress-nginx
spec:
type: NodePort
type: ClusterIP
ports:
- name: http
port: 80
Expand Down Expand Up @@ -62,4 +62,4 @@ spec:
selector:
app.kubernetes.io/name: ingress-nginx
app.kubernetes.io/instance: ingress-nginx
app.kubernetes.io/component: controller
app.kubernetes.io/component: controller
2 changes: 1 addition & 1 deletion charts/akash-provider/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.177.0
version: 0.178.0

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
Expand Down
38 changes: 19 additions & 19 deletions charts/akash-provider/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -63,25 +63,25 @@ minimumbalance: "10000000"

deploymentnetworkpoliciesenabled: "false"

# providers are setting these based on their configuration,
# these cannot be generic, hence commented.
#attributes:
# - key: region
# value: us-west
# - key: host
# value: akash
# - key: tier
# value: community
# - key: organization
# value: akash.network
# - key: capabilities/storage/1/class
# value: default
# - key: capabilities/storage/1/persistent
# value: true
# - key: capabilities/storage/2/class
# value: beta2
# - key: capabilities/storage/2/persistent
# value: true
# providers are setting these based on their configuration,
# these cannot be generic, hence commented.
# attributes:
# - key: region
# value: us-west
# - key: host
# value: akash
# - key: tier
# value: community
# - key: organization
# value: akash.network
# - key: capabilities/storage/1/class
# value: default
# - key: capabilities/storage/1/persistent
# value: true
# - key: capabilities/storage/2/class
# value: beta2
# - key: capabilities/storage/2/persistent
# value: true

debug: "false"

Expand Down
2 changes: 1 addition & 1 deletion charts/akash-rook/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.31.0
version: 0.32.0

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
Expand Down
3 changes: 1 addition & 2 deletions charts/akash-rook/values.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@

useAllNodes: false
useAllDevices: true

Expand All @@ -20,5 +19,5 @@ persistent_storage:
class: beta2

nodes:
- name: "node-a" # add the names of the nodes that ceph should use for storage
- name: "node-a" # add the names of the nodes that ceph should use for storage
config: ""

0 comments on commit 621e584

Please sign in to comment.