-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature to improve stats app charts #347
Feature to improve stats app charts #347
Conversation
Hey @forbesus I just tested and it works great! I have a few modifications requirements:
Thanks for your contribution! |
apps/stats-web/package.json
Outdated
"lucide-react": "^0.292.0", | ||
"moment": "^2.30.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove moment and use data-fns
, that's the library we use in other projects for time based functions.
? rangedData.map(_snapshot => ( | ||
{ | ||
time: moment.utc(_snapshot.date).format('YYYY-MM-DD'), | ||
value: _snapshot.value |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a unitFn called in the previous code y: roundDecimal(snapshotMetadata.unitFn(_snapshot.value).value)
which is probably why the values don't match.
Hello @baktun14 i fixed and completed |
@forbesus Great, I will check today. |
@forbesus There's a bug when changing the time range, it duplicates the graph. I'm investigating it. |
Hello @baktun14 I checked it but I have a question |
It doesn't change the behavior for me |
Hello @baktun14 |
@forbesus It works great! |
Great work @forbesus ! I fixed a resize issue and theme issue, but otherwise all is good to merge. |
Thank you @baktun14 |
refs #298