Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated examples and add integration tests #103

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jaseemuddinn
Copy link

  • examples/get_lease_status.ts

    • Updated getRpc function to use a valid RPC endpoint
    • Updated QueryLeaseRequest object with valid parameters
    • Added error handling for client.Lease call
  • examples/get_deployments.ts

    • Updated getRpc function to use a valid RPC endpoint
    • Updated QueryDeploymentsRequest object with valid parameters
    • Added error handling for client.Deployments call
  • tests/test_examples.ts

    • Imported necessary modules and functions
    • Wrote test cases for each example in the examples directory
    • Used exec to run each example and verify the output
  • examples/README.md

    • Added instructions on running the integration tests
    • Updated the examples to reflect the changes made
  • .github/workflows/test.yml

    • Added a new job to run the integration tests
    • Used npm test to run the tests

* **examples/get_lease_status.ts**
  - Updated `getRpc` function to use a valid RPC endpoint
  - Updated `QueryLeaseRequest` object with valid parameters
  - Added error handling for `client.Lease` call

* **examples/get_deployments.ts**
  - Updated `getRpc` function to use a valid RPC endpoint
  - Updated `QueryDeploymentsRequest` object with valid parameters
  - Added error handling for `client.Deployments` call

* **tests/test_examples.ts**
  - Imported necessary modules and functions
  - Wrote test cases for each example in the `examples` directory
  - Used `exec` to run each example and verify the output

* **examples/README.md**
  - Added instructions on running the integration tests
  - Updated the examples to reflect the changes made

* **.github/workflows/test.yml**
  - Added a new job to run the integration tests
  - Used `npm test` to run the tests
@gosuri gosuri requested a review from baktun14 December 15, 2024 06:24
@baktun14
Copy link
Contributor

I tried running the tests locally and they fail to execute because the npm test command uses the tap library to run the tests.

Copy link
Contributor

@baktun14 baktun14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are significant changes coming to the library following the upgrade to Cosmos SDK 47. We need to:

  1. Wait for the new changes on akash-api for the latest protobuf types
  2. Adapt the examples/tests to make them work with the latest changes
  3. Make the examples/tests run on sandbox

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants