-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change additional output type & skip empty optional arguments #104
Conversation
@akash-akya, I tried |
Thanks for quick check!
👍🏼. Makes sense to just wait a bit more for it to be stable. I am thinking if we need something like |
TLDR; Some small incompatibilities I can work around. I spoke too soon because I tested on master before you merge. Some small issue I can easily work around.
There is one other failing tests but the cause is not immediately clear. It is coming from |
I see. Let me know if you need any help with that, I can create a PR.
It should be |
All good Akash, they are easy fixes and a cleaner API so happy to push another Do you have a view on when you please to release this version of |
Well then nothing is pending from my side, I'll create a release now. |
Sounds good, I'll get my lib back in shape after you publish and do the same. Glad you're still motivate by working on |
Thanks! Yes, still have a lot of motivation, only wish I had more time to spare, anw I'll complain about time some other day. Few things I have on my mind in no order:
I am open to some other important changes as well if you have something on mind. |
@kipcole9 |
I'm very interested in where to you get to with those "roadmap" items - very interesting!
|
Hi @kipcole9! I am making few breaking changes, if possible can you check if this breaks
Image
?Btw, I also made few other changes in the master - #103. Notably, added limited math operators similar to Image :)