Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new pip to solve pytest/attrs version conflict #107

Merged
merged 1 commit into from
Dec 19, 2020

Conversation

akaihola
Copy link
Owner

@akaihola akaihola commented Dec 18, 2020

With old pip we got:

$ pip install -e '.[isort,test]'
[...]
Collecting pytest-mypy; extra == "test"
  Using cached pytest_mypy-0.8.0-py3-none-any.whl (6.6 kB)
Collecting pytest>=6.1.0; extra == "test"
  Downloading pytest-6.2.1-py3-none-any.whl (279 kB)
[...]
Requirement already satisfied: attrs>=19.0 in /home/travis/virtualenv/python3.7.1/lib/python3.7/site-packages (from pytest-mypy; extra == "test"->darker==1.2.2.dev0) (19.1.0)
[...]
ERROR: pytest 6.2.1 has requirement attrs>=19.2.0, but you'll have attrs 19.1.0 which is incompatible.
[...]
Successfully installed appdirs-1.4.4 astroid-2.4.2 black-20.8b1 click-7.1.2 darker filelock-3.0.12 flake8-3.8.4 iniconfig-1.1.1 isort-5.6.4 lazy-object-proxy-1.4.3 mccabe-0.6.1 mypy-0.790 mypy-extensions-0.4.3 pathspec-0.8.1 py-1.10.0 pycodestyle-2.6.0 pyflakes-2.2.0 pygments-2.7.3 pylint-2.6.0 pytest-6.2.1 pytest-darker-0.1.2 pytest-flake8-1.0.7 pytest-isort-1.2.0 pytest-mypy-0.8.0 regex-2020.11.13 toml-0.10.2 typed-ast-1.4.1 typing-extensions-3.7.4.3 wrapt-1.12.1
$ pytest
Traceback (most recent call last):
  [...]
  File "/home/travis/virtualenv/python3.7.1/lib/python3.7/site-packages/_pytest/_code/code.py", line 942, in <module>
    @attr.s(eq=False)
TypeError: attrs() got an unexpected keyword argument 'eq'

The command "pytest" exited with 1.

`
After upgrading pip, we get this instead:

$ pip install -e '.[isort,test]'
[...]
Collecting pytest>=6.1.0
Using cached pytest-6.2.1-py3-none-any.whl (279 kB)
[...]
Collecting attrs>=19.2.0
Downloading attrs-20.3.0-py2.py3-none-any.whl (49 kB)
[...]
Successfully installed appdirs-1.4.4 astroid-2.4.2 attrs-20.3.0 black-20.8b1 click-7.1.2 darker filelock-3.0.12 flake8-3.8.4 iniconfig-1.1.1 isort-5.6.4 lazy-object-proxy-1.4.3 mccabe-0.6.1 mypy-0.790 mypy-extensions-0.4.3 pathspec-0.8.1 py-1.10.0 pycodestyle-2.6.0 pyflakes-2.2.0 pygments-2.7.3 pylint-2.6.0 pytest-6.2.1 pytest-darker-0.1.2 pytest-flake8-1.0.7 pytest-isort-1.2.0 pytest-mypy-0.8.0 regex-2020.11.13 toml-0.10.2 typed-ast-1.4.1 typing-extensions-3.7.4.3 wrapt-1.12.1
$ pytest
[...]
The command "pytest" exited with 0.

With old pip we got:

  $ pip install -e '.[isort,test]'
  [...]
  Collecting pytest-mypy; extra == "test"
    Using cached pytest_mypy-0.8.0-py3-none-any.whl (6.6 kB)
  Collecting pytest>=6.1.0; extra == "test"
    Downloading pytest-6.2.1-py3-none-any.whl (279 kB)
  [...]
  Requirement already satisfied: attrs>=19.0 in /home/travis/virtualenv/python3.7.1/lib/python3.7/site-packages (from pytest-mypy; extra == "test"->darker==1.2.2.dev0) (19.1.0)
  [...]
  ERROR: pytest 6.2.1 has requirement attrs>=19.2.0, but you'll have attrs 19.1.0 which is incompatible.
  [...]
  Successfully installed appdirs-1.4.4 astroid-2.4.2 black-20.8b1 click-7.1.2 darker filelock-3.0.12 flake8-3.8.4 iniconfig-1.1.1 isort-5.6.4 lazy-object-proxy-1.4.3 mccabe-0.6.1 mypy-0.790 mypy-extensions-0.4.3 pathspec-0.8.1 py-1.10.0 pycodestyle-2.6.0 pyflakes-2.2.0 pygments-2.7.3 pylint-2.6.0 pytest-6.2.1 pytest-darker-0.1.2 pytest-flake8-1.0.7 pytest-isort-1.2.0 pytest-mypy-0.8.0 regex-2020.11.13 toml-0.10.2 typed-ast-1.4.1 typing-extensions-3.7.4.3 wrapt-1.12.1
  $ pytest
  Traceback (most recent call last):
    [...]
    File "/home/travis/virtualenv/python3.7.1/lib/python3.7/site-packages/_pytest/_code/code.py", line 942, in <module>
      @attr.s(eq=False)
  TypeError: attrs() got an unexpected keyword argument 'eq'

  The command "pytest" exited with 1.

After upgrading pip, we get this instead:

  $ pip install -e '.[isort,test]'
  [...]
  Collecting pytest>=6.1.0
    Using cached pytest-6.2.1-py3-none-any.whl (279 kB)
  [...]
  Collecting attrs>=19.2.0
    Downloading attrs-20.3.0-py2.py3-none-any.whl (49 kB)
  [...]
  Successfully installed appdirs-1.4.4 astroid-2.4.2 attrs-20.3.0 black-20.8b1 click-7.1.2 darker filelock-3.0.12 flake8-3.8.4 iniconfig-1.1.1 isort-5.6.4 lazy-object-proxy-1.4.3 mccabe-0.6.1 mypy-0.790 mypy-extensions-0.4.3 pathspec-0.8.1 py-1.10.0 pycodestyle-2.6.0 pyflakes-2.2.0 pygments-2.7.3 pylint-2.6.0 pytest-6.2.1 pytest-darker-0.1.2 pytest-flake8-1.0.7 pytest-isort-1.2.0 pytest-mypy-0.8.0 regex-2020.11.13 toml-0.10.2 typed-ast-1.4.1 typing-extensions-3.7.4.3 wrapt-1.12.1
  $ pytest
  [...]
  The command "pytest" exited with 0.
@akaihola akaihola added the CI label Dec 18, 2020
@akaihola akaihola added this to the 1.2.2 milestone Dec 18, 2020
@akaihola akaihola requested a review from sherbie December 18, 2020 20:39
@akaihola akaihola self-assigned this Dec 18, 2020
@akaihola akaihola added the bug Something isn't working label Dec 19, 2020
@akaihola akaihola requested a review from samoylovfp December 19, 2020 11:29
@akaihola akaihola merged commit 52bfb84 into master Dec 19, 2020
@akaihola akaihola deleted the travis-ci-pip-upgrade branch December 19, 2020 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CI
Projects
Development

Successfully merging this pull request may close these issues.

1 participant