Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
sql: fix bug with multi-statement implicit txn schema changes and Bind
For legacy reasons, we were resetting the descriptor collection state in Bind if we thought we were not in a transaction. Since cockroachdb#76792, we're always in a transaction. You might think that'd mean that the logic would not run. Sadly, for other still unclear reasons, when in an implicit transaction `(*connExecutor).getTransactionState()` returns `NoTxnStateStr`. The end result was that we'd erroneously reset our descriptor state in the middle of a multi- statement implicit transaction if bind was invoked. Fixes cockroachdb#82921 Release note (bug fix): Fixed a bug which could lead to errors when running multiple schema change statements in a single command using a driver that uses the extended pgwire protocol internally (Npgsql in .Net as an example). These errors would have the form "attempted to update job for mutation 2, but job already exists with mutation 1".
- Loading branch information