Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
34737: roachtest: don't write tpchbench results in scalefactor subdirectory r=jordanlewis a=asubiotto

There was no need to do this, we want to treat scalefactor runs as
different tests (i.e. show performance evolution over time for each one).

Release note: None

Co-authored-by: Alfonso Subiotto Marqués <[email protected]>
  • Loading branch information
craig[bot] and asubiotto committed Feb 8, 2019
2 parents 033b346 + 0379565 commit 3981ac6
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions pkg/cmd/roachtest/tpchbench.go
Original file line number Diff line number Diff line change
Expand Up @@ -81,10 +81,9 @@ func runSQL20Bench(ctx context.Context, t *test, c *cluster, b tpchBenchSpec) {

// Run with only one worker to get best-case single-query performance.
cmd := fmt.Sprintf(
"./workload run querybench --db=tpch --concurrency=1 --query-file=%s --duration=5m {pgurl%s} --histograms=logs/scalefactor=%d/stats.json",
"./workload run querybench --db=tpch --concurrency=1 --query-file=%s --duration=5m {pgurl%s} --histograms=logs/stats.json",
filename,
roachNodes,
b.ScaleFactor,
)
if err := c.RunE(ctx, loadNode, cmd); err != nil {
t.Fatal(err)
Expand Down

0 comments on commit 3981ac6

Please sign in to comment.