Use BuildService as provider of Grgit #160
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
any updates on this one? my team would also appreciate this :) |
Hey @kibotu , until @ajoberstar reviews this, you can try this change from jitpack.io. By adding a repo I tested this manually myself, but would very much like to hear feedback from others. Maybe, if others confirm that it's working, it could speed up review process too :) |
# Conflicts: # reckon-gradle/build.gradle # reckon-gradle/gradle/dependency-locks/compileClasspath.lockfile # reckon-gradle/gradle/dependency-locks/runtimeClasspath.lockfile # reckon-gradle/gradle/dependency-locks/testCompileClasspath.lockfile # reckon-gradle/gradle/dependency-locks/testRuntimeClasspath.lockfile
|
As of 0.14.0 both grgit and reckon are configuration cache safe and leverage BuildService to provide the repositories. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a BuildService, which serves as a provider of
Grgitinstance. It replacesgrgit-gradleplugin and instead of usingGrgitfrom extension property and closing it inbuildFinishedlistener allows gradle to manage it's lifecycle and close when closing build service. This addresses the issue reported at ajoberstar/grgit#333 and ajoberstar/grgit#322, but since grgit is no longer actively maintained (as per readme), I decided to implement this change here.The biggest downside is that build services have been introduced only in Gradle 6.1, so this would require raising minimal supported version, which is represented in updated tests.
I'm using
reckonin my projects and really like the results and appreciate the work, that has been done. I would really like to hear feedback on this and adjust my changes accordingly.