Skip to content
This repository has been archived by the owner on Oct 5, 2018. It is now read-only.

If the tagStrategy.prefixNameWithV is set to false generated message prints entire history for each release #149

Closed
sdavids13 opened this issue Dec 18, 2015 · 3 comments

Comments

@sdavids13
Copy link
Contributor

https://github.com/ajoberstar/gradle-git/blob/master/src/main/groovy/org/ajoberstar/gradle/git/release/opinion/OpinionReleasePlugin.groovy#L67

Previous version is hard-coded with a "v" prefix and doesn't actually take into account tagStrategy.prefixNameWithV setting thus the previous tag is never found and the history is not trimmed resulting in the entire repo history being printed for every release.

@ajoberstar
Copy link
Owner

Sorry for the delay. My rationale was that the "opinionated" plugin didn't need to take into account different configuration, however I can see how that's a pain in this situation.

This one's not high on my priority list, but I would take a pull request.

@ajoberstar ajoberstar added this to the wishlist milestone Jan 2, 2016
sdavids13 added a commit to sdavids13/gradle-git that referenced this issue Jan 2, 2016
… `release.tagStrategy.prefixNameWithV = false`, previously the prior tag wouldn't be found.
@sdavids13
Copy link
Contributor Author

Opened new PR: #152

@ajoberstar ajoberstar modified the milestones: 1.4.0, wishlist Jan 2, 2016
ajoberstar added a commit that referenced this issue Jan 2, 2016
@ajoberstar
Copy link
Owner

Nice turnaround. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants